ref(opentelemetry): Remove enhanceDscWithOpenTelemetryRootSpanName - #22797
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
July 29, 2026 07:53
mydea
requested review from
andreiborza and
isaacs
and removed request for
a team
July 29, 2026 07:53
andreiborza
approved these changes
Jul 29, 2026
mydea
force-pushed
the
fn/remove-dsc-enhancer
branch
from
July 29, 2026 08:32
c293a03 to
05ad85e
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
mydea
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
July 29, 2026 13:34
more fixes moar fixes fixxx
Core's `getDynamicSamplingContext` now derives the DSC transaction name and handles the `url` source guard directly from the root span, making the OpenTelemetry-specific DSC enhancer redundant. Remove the util and its call sites in node, vercel-edge, and the otel test helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
With enhanceDscWithOpenTelemetryRootSpanName removed, the DSC for a continued remote trace is built by core's getDynamicSamplingContextFromSpan, which derives `sampled` from the root span's binary trace flags. That cannot tell a deferred sampling decision (which lives in the OTel trace state) apart from a definitive unsampled one — both read as `traceFlags: NONE` — so a deferred remote trace wrongly propagated `sentry-sampled=false`. Reconcile the span-derived DSC with the OTel sampling decision resolved by `getSamplingDecision` in the propagator's remote-span branch: drop `sampled` when deferred, and drop the transaction name when definitively unsampled (matching the OTel SDK, whose unsampled spans are nameless). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
reconcileDscSampled must only touch a DSC that core freshly derives from the span's binary trace flags. When a continued remote trace froze its own DSC on the trace state, getDynamicSamplingContextFromSpan returns it verbatim and the propagation spec treats it as immutable — reconciling would strip its `transaction` (on an unsampled trace) or rewrite `sampled`. This mirrors the old createDsc handler, which only ran on core's fresh-generate path and never saw a frozen DSC. Guard on the presence of an incoming `sentry.dsc` trace-state entry and skip reconciliation in that case. Adds a regression test for a directly-injected unsampled remote span with a frozen incoming DSC. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
fn/remove-dsc-enhancer
branch
from
July 29, 2026 13:35
b5eb299 to
baf73c5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit baf73c5. Configure here.
| @@ -1,7 +1,5 @@ | |||
| export { getScopesFromContext } from './utils/contextData'; | |||
|
|
|||
| export { enhanceDscWithOpenTelemetryRootSpanName } from './utils/enhanceDscWithOpenTelemetryRootSpanName'; | |||
There was a problem hiding this comment.
Public API removed without migration docs
Medium Severity
enhanceDscWithOpenTelemetryRootSpanName was a public export of @sentry/opentelemetry and is removed here with no deprecation path and no entry under the @sentry/opentelemetry section in MIGRATION.md, where other public removals for that package are already listed. This violates the PR review rule on removal of publicly exported APIs / public API changes without proper deprecation notices. I flagged this because it was mentioned in the rules file.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit baf73c5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #22712.
With the span name/source inference reworked in #22712, core's
getDynamicSamplingContextnow derives the DSC transaction name from the root span and applies theurlsource guard itself. That makes the OpenTelemetry-specificcreateDschandlerenhanceDscWithOpenTelemetryRootSpanNameredundant — it was only there to re-derive the name/source viaparseSpanDescriptionbefore core did so natively.This removes the util along with its call sites in
@sentry/node,@sentry/vercel-edge, and the opentelemetry test helper, and drops it from the package's public exports.Since the enhancer is a public export of
@sentry/opentelemetry, its removal is technically breaking for anyone importing it directly — which is why this targets the breaking-change branch #22712.